VoIP Mailing List Archives
Mailing list archives for the VoIP community |
|
| View previous topic :: View next topic |
| Author |
Message |
t.rechberger at gmail.com
Guest
|
 Posted: Thu Mar 20, 2014 9:56 am Post subject: [asterisk-users] fromdomain not honored on outbound INVITE r |
 |
|
https://issues.asterisk.org/jira/browse/ASTERISK-20841
The patch was already posted by someone but then was deleted because of
guide lines. Is it really that hard to fix? Since 1.8 there is this
problem but nobody seems to care about. Asterisk isnt only used with
itsp who dont care about fromdomain. Or are the developers saying, we
dont care about people who are using Asterisk in smaller installations?
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
New to Asterisk? Join us for a live introductory webinar every Thurs:
http://www.asterisk.org/hello
asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-users |
|
| Back to top |
|
 |
jcolp at digium.com
Guest
|
| Posted: Thu Mar 20, 2014 10:13 am Post subject: [asterisk-users] fromdomain not honored on outbound INVITE r |
|
|
Thomas Rechberger wrote:
| Quote: | https://issues.asterisk.org/jira/browse/ASTERISK-20841
The patch was already posted by someone but then was deleted because of
guide lines. Is it really that hard to fix? Since 1.8 there is this
problem but nobody seems to care about. Asterisk isnt only used with
itsp who dont care about fromdomain. Or are the developers saying, we
dont care about people who are using Asterisk in smaller installations?
|
It's hard in the sense that someone has to figure out in chan_sip how to
fix it, do so, get it tested, and also confirm it doesn't cause any
regressions. Simply committing something isn't enough. I'd rather not
break chan_sip in some other way. ^_^ Nobody has yet done this.
That being said... this specific issue was brought up to me by a friend
and I was actually going to look at it over an upcoming weekend when I
have time. Can I guarantee it? No, but I'm going to try. That's how much
I care. Can I do this for every issue? No. I work 8+ hours a day as it
is on Asterisk and also some on the weekends. So many issues, not enough
time. ^_^
Cheers,
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
New to Asterisk? Join us for a live introductory webinar every Thurs:
http://www.asterisk.org/hello
asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-users |
|
| Back to top |
|
|
t.rechberger at gmail.com
Guest
|
| Posted: Thu Mar 20, 2014 6:43 pm Post subject: [asterisk-users] fromdomain not honored on outbound INVITE r |
|
|
Am 20.03.2014 16:07, schrieb Joshua Colp:
| Quote: | That being said... this specific issue was brought up to me by a friend
and I was actually going to look at it over an upcoming weekend when I
have time. Can I guarantee it? No, but I'm going to try. That's how much
I care. Can I do this for every issue? No. I work 8+ hours a day as it
is on Asterisk and also some on the weekends. So many issues, not enough
time. ^_^
|
That'll be great, i would look into this myself but i have not any clue
about C.
But should be able to test it.
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
New to Asterisk? Join us for a live introductory webinar every Thurs:
http://www.asterisk.org/hello
asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-users |
|
| Back to top |
|
|
t.rechberger at gmail.com
Guest
|
| Posted: Fri Mar 21, 2014 9:50 am Post subject: [asterisk-users] fromdomain not honored on outbound INVITE r |
|
|
meanwhile i got an answer from fprior who was testing patch already.
add this code to chan_sip.c :
/* Allow domain to be overridden */
if (!ast_strlen_zero(p->fromdomain))
d = p->fromdomain;
else /* Save for any further attempts */
ast_string_field_set(p, fromdomain, d);
after this one (approx. at line 13741)
/* Allow user to be overridden */
if (!ast_strlen_zero(p->fromuser))
l = p->fromuser;
else /* Save for any further attempts */
ast_string_field_set(p, fromuser, l);
on 11.x it should after fromname section, but i guess wont matter.
Will test this soon.
The code is really that simple, is it really needed to have it signed
from the author?
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
New to Asterisk? Join us for a live introductory webinar every Thurs:
http://www.asterisk.org/hello
asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-users |
|
| Back to top |
|
|
jcolp at digium.com
Guest
|
| Posted: Mon Mar 24, 2014 4:43 pm Post subject: [asterisk-users] fromdomain not honored on outbound INVITE r |
|
|
Thomas Rechberger wrote:
| Quote: | meanwhile i got an answer from fprior who was testing patch already.
add this code to chan_sip.c :
/* Allow domain to be overridden */
if (!ast_strlen_zero(p->fromdomain))
d = p->fromdomain;
else /* Save for any further attempts */
ast_string_field_set(p, fromdomain, d);
after this one (approx. at line 13741)
/* Allow user to be overridden */
if (!ast_strlen_zero(p->fromuser))
l = p->fromuser;
else /* Save for any further attempts */
ast_string_field_set(p, fromuser, l);
on 11.x it should after fromname section, but i guess wont matter.
Will test this soon.
The code is really that simple, is it really needed to have it signed
from the author?
|
Modified fix is in all branches 1.8 and up. Just to give a glimpse into
what I did:
1. Went back into past versions of Asterisk to see how long stuff has
been this way
2. Looked to see if it was left out on purpose
3. Thought about the real world implications
4. Looked over required change
5. Committed to all branches
Cheers,
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
New to Asterisk? Join us for a live introductory webinar every Thurs:
http://www.asterisk.org/hello
asterisk-users mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-users |
|
| Back to top |
|
|
|
|
|
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
|
Powered by phpBB © 2001, 2005 phpBB Group
|
Search
