VoIP Mailing List Archives

[scott.ellis at novatex...]

So I decided to hack the code to see if I could just get it to do what I
wanted - assuming some kind of error in the options setting.

First I changed the state change code to just skip straight to IDLE

if (!event->channel->ring_count && (event->channel->state == ZAP_CHANNEL_STATE_DOWN && !zap_test_flag(event->channel, ZAP_CHANNEL_INTHREAD))) {
// if (zap_test_flag(analog_data, ZAP_ANALOG_CALLERID)) {
// zap_set_state_locked(event->channel, ZAP_CHANNEL_STATE_GET_CALLERID);
// } else {
zap_set_state_locked(event->channel, ZAP_CHANNEL_STATE_IDLE);
// }
event->channel->ring_count = 1;
zap_mutex_unlock(event->channel->mutex);
locked = 0;
zap_thread_create_detached(zap_analog_channel_run, event->channel);
} else {
event->channel->ring_count++;
}

So we skip the GET_CALLERID state altogether.

This generated an illegal state change message cannot go from DOWN to IDLE

So then changed the code to

if (!event->channel->ring_count && (event->channel->state == ZAP_CHANNEL_STATE_DOWN && !zap_test_flag(event->channel, ZAP_CHANNEL_INTHREAD))) {
// if (zap_test_flag(analog_data, ZAP_ANALOG_CALLERID)) {
zap_set_state_locked(event->channel, ZAP_CHANNEL_STATE_GET_CALLERID);
// } else {
zap_set_state_locked(event->channel, ZAP_CHANNEL_STATE_IDLE);
// }
event->channel->ring_count = 1;
zap_mutex_unlock(event->channel->mutex);
locked = 0;
zap_thread_create_detached(zap_analog_channel_run, event->channel);
} else {
event->channel->ring_count++;
}

Allowing the state change to GET_CALLERID, then immediately to IDLE.

This works perfectly - the call is answered straight away. At the moment
I don't know enough about linux debugging to step through the parameter
code to see why setting get caller ID to false in openzap.conf.xml does
not get passed through, but even if it does the current code will still
run into the illegal state change error.

2009-01-15 21:59:18 [DEBUG] ozmod_analog.c:744 process_event() EVENT
[RING_START][1:1] STATE [DOWN]
2009-01-15 21:59:18 [DEBUG] ozmod_analog.c:760 process_event() Changing
state on 1:1 from DOWN to GET_CALLERID
2009-01-15 21:59:18 [DEBUG] ozmod_analog.c:762 process_event() Changing
state on 1:1 from GET_CALLERID to IDLE
2009-01-15 21:59:18 [DEBUG] ozmod_analog.c:239 zap_analog_channel_run()
ANALOG CHANNEL thread starting.
2009-01-15 21:59:18 [DEBUG] ozmod_analog.c:410 zap_analog_channel_run()
Executing state handler on 1:1 for IDLE
2009-01-15 21:59:18 [DEBUG] mod_openzap.c:1165 on_fxo_signal() got FXO
sig 1:1 [START]
2009-01-15 21:59:18 [DEBUG] mod_openzap.c:340 tech_init() Set codec PCMU
20ms
2009-01-15 21:59:18 [DEBUG] mod_openzap.c:1137 zap_channel_from_event()
Connect inbound channel OpenZAP/1:1/1
2009-01-15 21:59:18 [NOTICE] switch_channel.c:565
switch_channel_set_name() New Channel OpenZAP/1:1/1
[8e2a55c8-e2f3-11dd-adfd-6d934f226ffd]

Will go and put this into JIRA in the next couple of days.

Scott

Scott Ellis wrote: